On Wed, Sep 01, 2010 at 03:17:27PM -0400, Eric Millbrandt wrote: > The problem there is the return value of poll_sample currently is not > being checked, so wm97xx_read_aux_adc() is returning invalid data. That > could be fixed to either keep polling until RC_VALID or a timeout is hit > is returned or return an error to the calling function and letting it > decide what to do. I don't like the second option because it creates a > pathologic failure: I think (without having thought through it all so I may have missed something) that the best thing for the pathalogical case is to have a limited number of goes at restoring things and then just stop the digitiser - that will leave things restored while still providing a guaranteed exit case which should be recoverable (since everything will be halted). Does that seem sensible to you? -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
