On Wed, 1 Sep 2010 at 13:19:25 Mark Brown wrote: > On Wed, Sep 01, 2010 at 10:52:10AM -0400, Eric Millbrandt wrote: > >> Saving the state of the digitizers seems unnecessary since the next >> sample will rewrite those registers. It also causes an unnecessary >> sample to occur if the previous state was a sample. This will cause >> the wrong sample to be returned on the next call to > wm97xx_read_aux_adc(). > > You need to explain how this interacts with both polling and continuous > touchscreen modes - saying that it seems unneeded feels a little fuzzy. > Note that this will also clear the current digitiser configuration before > it starts the AUXADC so it's not a simple save of the values. Hi Mark, You are right; the current digitizer settings do need to be cleared. I was testing in the polling touchscreen mode and overlooked that fact. But do we want to restore the POLL bit if it happened to be set? Continuous mode does not need it and it looks like wm9712_poll_*() will set the POLL bit again when it needs a touchscreen measurement. Eric -DISCLAIMER: an automatically appended disclaimer may follow. By posting- -to a public e-mail mailing list I hereby grant permission to distribute- -and copy this message.- This e-mail and the information, including any attachments, it contains are intended to be a confidential communication only to the person or entity to whom it is addressed and may contain information that is privileged. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the sender and destroy the original message. Thank you. Please consider the environment before printing this email. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
