Re: [RFC] Input: wm97xx-core - Remove save state from wm97xx_read_aux_adc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 01, 2010 at 10:52:10AM -0400, Eric Millbrandt wrote:

> Saving the state of the digitizers seems unnecessary since the next
> sample will rewrite those registers.  It also causes an unnecessary
> sample to occur if the previous state was a sample.  This will cause
> the wrong sample to be returned on the next call to wm97xx_read_aux_adc().

You need to explain how this interacts with both polling and continuous
touchscreen modes - saying that it seems unneeded feels a little fuzzy.
Note that this will also clear the current digitiser configuration
before it starts the AUXADC so it's not a simple save of the values.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux