Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, May 28 2006, Jens Axboe wrote:
> On Sat, May 27 2006, Jeff Garzik wrote:
> > Jens Axboe wrote:
> > >index b80d2e7..80fb1f9 100644
> > >--- a/include/linux/libata.h
> > >+++ b/include/linux/libata.h
> > >@@ -742,7 +742,7 @@ static inline u8 ata_busy_wait(struct at
> > > 
> > > static inline u8 ata_wait_idle(struct ata_port *ap)
> > > {
> > >-	u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
> > >+	u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000);
> > 
> > 
> > Ouch.  That will slow down boot for a lot of otherwise-untouched users, 
> > if that makes it in...  :(
> 
> Not proposing it for inclusion, just posted what I had in entirety to
> avoid confusion. I made that change to potentially avoid recompiling
> again for retesting. I can test without that too, I guess I will now
> because we have no clear results so far.

With that hunk restored to normal, no change. Resume still works, status
is still 80/50/50.

-- 
Jens Axboe

-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux