Jens Axboe wrote:
On Sat, May 27 2006, Jeff Garzik wrote:
Jens Axboe wrote:
This is fine with me, Jeff originally complained it was a layering
violation. Unless he really objects, I'd say go for that for 2.6.17 - well
actually moving it inside the ATA_FLAG_SUSPENDED case is clearly better.
It breaks 2.6.1[89] stuff, but whatever. Go ahead and apply Linus's
patch. I'll pick up the pieces post 2.6.17.
Linus' patch doesn't work for me, seems I still need a little delay
before waiting for BSY clear. I'm testing a small additional hack to the
pci resume function.
If it works better for people, just doing an msleep() or mdelay() in
device suspend would be better than polling BSY.
A delay at least works for FIS-based controllers and PMs...
Post 2.6.17, a lot of work needs to go into actually re-initing the
hardware, since the current suspend resumes to silicon defaults rather
than BIOS defaults (and ata_piix doesn't have a controller reset).
Jeff
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
