Re: [PATCH] Re: 2.6.17-rc5-git1: regression: resume from suspend(RAM) fails: libata issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
Jens Axboe wrote:
index b80d2e7..80fb1f9 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -742,7 +742,7 @@ static inline u8 ata_busy_wait(struct at
static inline u8 ata_wait_idle(struct ata_port *ap)
 {
-    u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 1000);
+    u8 status = ata_busy_wait(ap, ATA_BUSY | ATA_DRQ, 200000);


Ouch. That will slow down boot for a lot of otherwise-untouched users,

Really?  If a drive claims to be BUSY, then it shouldn't accept a new command.

But yes, this may be a bit too mainline to risk at this point,
given controller quirks and the like that may be spoofing the status.

Cheers
-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux