On Sat, 15 Mar 2008 23:23:51 +0100 Jan Hoogenraad <jan-conceptronic@xxxxxxxx> wrote: > > Due to several issues I've noticed at the driver, I opted, for now, to add it > > as a separate tree. This way, we can fix things there, without affecting the > > staging tree. I've made it available at: > > http://linuxtv.org/hg/~mchehab/rtl2831 > Thanks a lot. This way, the people involved have a place to focus on. > Now, I need to find a way to synchronise my tree with this directory. > I'll do some reading on the mercurial. Kdiff3 has a very nice algorithm to see the differences on a code with different CodingStyles. Anyway, this could be a pain. > I have some scripts to convert things I receive from Realtek. > I'll add the new directory names and Lindent at least. > > Also, I noticed that nobody, on RealTek signed it. It would be interesting if > > someone there could send us a SOB for the first changeset: > > http://linuxtv.org/hg/~mchehab/rtl2831/rev/bb7749446173 > Please explain the abbrreviation SOB, and if possible send the text. SOB - Signed-off-by: It should be useful for you to take a look on README.patches [1]. [1] http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches > Would you like to have a paper copy, or is e-mail confirmation to you > sufficient ? Just an e-mail with their SOBs. > The text I added in the header is vetted by people from Realtek. They can change the text. The only requirement is that the code should be licensed with GPLv2. > They are eager to work together, and willing to learn. This is very good! With time we will learn how to cope together. > Unfortunately, I myself am completely new to linux development. It shouldn't take much time to learn ;) It is a completely different environment than what you'll have inside a company, since it is a community-driven work. So, all members of the community are freed to cope, comment and help with your work, sending you newer patches. Also, since kernel internal API's change, we need to handle patches that will change the API, testing they. > I'll add those specific cases to my import script; > I think that script should (due to the nature of the driver) get a > central role, as to keep updates automated. Yes, this seems to be the easiest way. > > 3) Name convention. Names are generally in lower case. Since we try to have all > > lines with maxsize=80, the better is trying to have shorter names. > > > > I don't think that it would be a good idea to replace all names inside the driver, > > since this will make your life harder, when receiving patches from Realtek. > > Anyway, please consider this if you need to touch on some var name. > > > > There are other comments I want to do, about the integration with the tree. I > > intend to do it later, after having a better understanding on how the driver > > works and what can be done to avoid code duplication with dvb core and to allow > > the usage of the tuners by other drivers. > Some of us have studied this already, and communicated with Realtek on > this, For example, they have an improved handling of the mt2060 tuner. > Decoupling the front end, setting this temporatily up as a new driver > (would the naming there be something like mt2060_for_rtl2831 ?) and then > integration have been on our wish list already. We did this kind of things already (for example, with saa711x). While this is not the ideal way, we can handle this. I suspect, however, that it is too late to merge the driver for 2.6.26 (the window for newer drivers should be opening soon, and the driver reviewing should happen before the opening of the windows). Considering this, we'll have a timeframe of about 8-10 weeks before the next merge window (for 2.6.27). Maybe this timeframe is enough to merge the required newer features on mt2060 and reuse it, instead of adding a newer one. My suggestion is to work with the separate tree and see the progress. > > Also, I'll need help from other developers on this large task ;) > I at least have a lot of people interested already for testing. > I've cc-ed them. Great. There are also the other guys from DVB ML that could also help on this. Cheers, Mauro _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
