Dear v4l maintainer:I have created a first version of the patch for the Freecom stick, based on the latest sources I received today from RealTek. I have received several updates per week from them during the fixing time, so I expect some updates later on.
I'm not very familiar with Mercurial / HG.I've put the sources into a separate directory, and created the patch with hg commit / hg export .... / hg rollback
It compiles with the latest v4l. It has been tested on my system only yet. Please review the way of submission. Mauro: Thanks for the help. I agree that this is probably the best thing to do. Unfortunately, Lindent does not fix errors that make checkpatch reports like the two below. tuner_mxl5005s.h: In '// I2C birdge module demod argument setting': tuner_mxl5005s.h:531: ERROR: do not use C99 // commentstuner_mxl5005s.h: In 'void mxl5005s_SetI2cBridgeModuleTunerArg(TUNER_MODULE * pTuner);':
tuner_mxl5005s.h:532: ERROR: "foo * bar" should be "foo *bar" Mauro Carvalho Chehab wrote:
On Sun, 09 Mar 2008 23:21:17 +0100 Jan Hoogenraad <jan-conceptronic@xxxxxxxx> wrote:Mauro: Thanks a lot for the comments.One clear problem with this particular driver is that the code that came from RealTek does not conform to the Linux C coding style.Would that be an objection for the steps below ?Considering that RealTek won't be interested on correcting the CodingStyle, IMO, the better would be to commit RealTek code as-is, with their SOB, and then adding an additional patch, authored by somebody else could fix the CodingStyle. A very simple patch to fix CodingStyle can be created by running kernel scripts/Lindent. Unfortunately, the results of this automatic tool are not perfect, but generally are acceptable.Furthermore, can you confirm linux-dvb@xxxxxxxxxxx as the submission address for the patch ?Yes. Please C/C me also at the submission e-mail. Cheers, Mauro
-- Jan Hoogenraad Hoogenraad Interface Services Postbus 2717 3500 GS Utrecht
<<attachment: p080314.patch.zip>>
_______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
