I see what you are trying to say about replacing the brace with a blank line.
I was trying to look through the CodingStyle document to find
out if there should be a blank line or not, and I couldn't find a definite answer.
For me personally, it seemed if there was a blank line after the if statement,
I could read the code a bit easier. But, I'm not the one extensively coding
or have the experience with the linux kernel as all of you possess.
I did find out where my careless mistake was, and I can change remove the
blank lines if you wish. I could always scrape this entire patch.
On Wed, 21 Sep 2011 05:36:33 -0400, Ian Abbott <abbotti@xxxxxxxxx> wrote:
On 2011-09-21 10:28, Dan Carpenter wrote:
On Wed, Sep 21, 2011 at 10:04:30AM +0100, Ian Abbott wrote:
And apart from being incorrect, was it worth it to save one line? (Most
of the closing braces were replaced by blank lines. Personally, I'd
rather keep the braces as it makes code changes less fragile.)
It's a kernel style thing.
Yes, I understand the reason for this style is to save vertical space
(and I do agree with most of CodingStyle), but since the patch mostly
replaced "closing brace lines" with "blank lines" it was hardly in the
spirit of that particular coding style rule!
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
