On 2011/09/20 08:54 PM, Greg KH wrote: > On Mon, Sep 19, 2011 at 07:49:45PM -0400, Ramesh Raj wrote: >> Fixed all brace coding style issues and some indents > > You obviously didn't actually test this patch, to verify that it was > correct :( > > Please be more careful in the future, and test your changes. > > Feel free to resend when you have fixed this up. And apart from being incorrect, was it worth it to save one line? (Most of the closing braces were replaced by blank lines. Personally, I'd rather keep the braces as it makes code changes less fragile.) -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
