On Wed, Sep 21, 2011 at 10:04:30AM +0100, Ian Abbott wrote: > On 2011/09/20 08:54 PM, Greg KH wrote: > > On Mon, Sep 19, 2011 at 07:49:45PM -0400, Ramesh Raj wrote: > >> Fixed all brace coding style issues and some indents > > > > You obviously didn't actually test this patch, to verify that it was > > correct :( > > > > Please be more careful in the future, and test your changes. > > > > Feel free to resend when you have fixed this up. > > And apart from being incorrect, was it worth it to save one line? (Most > of the closing braces were replaced by blank lines. Personally, I'd > rather keep the braces as it makes code changes less fragile.) > It's a kernel style thing. Btw, for the one that broke, the style anyways says that multi-line blocks get curly braces even if it's not needed for semantic reasons. So the fix would be to put the unmatched brace back, not to delete the other. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
