Re: [PATCH] staging: comedi: daqboard2000: fixed some checkpatch errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-09-21 10:28, Dan Carpenter wrote:
> On Wed, Sep 21, 2011 at 10:04:30AM +0100, Ian Abbott wrote:
>> And apart from being incorrect, was it worth it to save one line? (Most
>> of the closing braces were replaced by blank lines.  Personally, I'd
>> rather keep the braces as it makes code changes less fragile.)
> 
> It's a kernel style thing.

Yes, I understand the reason for this style is to save vertical space
(and I do agree with most of CodingStyle), but since the patch mostly
replaced "closing brace lines" with "blank lines" it was hardly in the
spirit of that particular coding style rule!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux