Re: [patch] Staging: rtl8192e: off by one in rtl8192_get_channel_map()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/21/2011 02:17 AM, Dan Carpenter wrote:
COUNTRY_CODE_MAX is not a valid country code.  We're off by one here.
This gets passed to Dot11d_Channelmap() where it's used as an offset
into the ChannelPlan[] array.

Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>

Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

Dan, good catch. Did this cause a problem, or did you find it while reading the code?

Larry



diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c
index 6530058..1beb04f 100644
--- a/drivers/staging/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl_core.c
@@ -1308,7 +1308,7 @@ static short rtl8192_get_channel_map(struct net_device *dev)
  		return -1;
  	}

-	if (priv->ChannelPlan>  COUNTRY_CODE_MAX) {
+	if (priv->ChannelPlan>= COUNTRY_CODE_MAX) {
  		printk(KERN_INFO "rtl819x_init:Error channel plan! Set to "
  		       "default.\n");
  		priv->ChannelPlan = COUNTRY_CODE_FCC;


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux