On Mon, 2007-05-21 at 14:11 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Bastien Nocera wrote: > > On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > > > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > > > On Mon, 21 May 2007, Richard Hughes wrote: > > > > > > You get full credits, of course, and I will wait an ACK from you before I > > > > > > push it anywhere. It was your idea, and your patch probably is just fine as > > > > > > far as "it works" goes, so you get to comment and offer suggestions before I > > > > > > merge it. > > > > > > > > > > One comment I was about to make, are the INPUT events emitted even > > > > > without a "echo enable,0xffff >/proc/acpi/ibm/hotkey"? > > > > > > > > No, they are not. > > > > > > Ick. > > > > Ick indeed. It should really be automatic (ie. no need to poke anywhere > > to get the events back to user-space). > > No way, no how. The firmware often does better at it. Does better than userspace? By taking control of the backlight brightness keys we can do clever things like keep turning the brightness up by as long as the brightness up button is pressed. Like I said before, on my X60, all the buttons do the hardware action even with the hotkeys enable. I'll update the bios later today, and see if this is still the case with the latest bios. > > For the additional keys, I mentioned to Richard using "KEY_F13" and > > above (really depending on the number of functions keys on those > > keyboards), for keys which can't be easily mapped to existing keycodes. > > Not nice. It is not a KEY_F13, I am not going to map to it by default. > What if someone plugs a USB keyboard that does have F13..F24 ? Well, I really wanted new keys in input.h, but we do need to get this working out of the box. The number of users that are going to enable the hotkeys at boot is going to be a fraction of one percent. I think we need a way to (at least) to toggle this as a module option. Would you accept a patch for this? Richard. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
