On Mon, 21 May 2007, Richard Hughes wrote: > > You get full credits, of course, and I will wait an ACK from you before I > > push it anywhere. It was your idea, and your patch probably is just fine as > > far as "it works" goes, so you get to comment and offer suggestions before I > > merge it. > > One comment I was about to make, are the INPUT events emitted even > without a "echo enable,0xffff >/proc/acpi/ibm/hotkey"? No, they are not. I am working on letting one change which input events are sent for each hotkey, though. I will also try to get the KEY_FN_* missing macros in input.h, but if that fails, well, at least it will be configurable. It is a pity the sonypi guys got some non-generic keys in there instead of asking for a set of 16 "KEY_MODELSPECIFC_1..16" or somesuch which we could use for these things. All FN keys should be something like that, in fact... or we should just work on expanding the !@#$ keycode space right away, trying to limit the usefulness of these things is a bad idea, anyway... > >From a end user perspective, this stuff should probably just work. I am still trying to get the input events routed to the core keyboard. Do you know how that can be archieved? Right now they work just fine, but you have to open and process the relevant event* device to get the events... > Thanks for your review - do you have a latest tree with the two patches > applied? You have my ACK for anything that adds input events. Heh. Soon. Let me fix the remaining bugs and I will post it as a git branch. When it is ready, I will send it for comments on linux-acpi and LKML (required due to the addition of stuff to input.h). It is already working on 2.6.20, though, with some rough edges on the keycode remap sysfs interface (it requires binary attributes, which I am dealing with for the first time in my life). -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
