> When the above is applied and compiled without NO_NORETURN, the extra > return may be optimized out by the compiler as your commit log messages > said, but wouldn't it introduce a new warning: > > builtin/commit.c: In function 'find_author_by_nickname': > builtin/commit.c:965: error: will never be executed > > under -Wunreachable-code? It may, but that option isn't set for git? -Andi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html