Andi Kleen <andi@xxxxxxxxxxxxxx> writes:
>> Please remember to think for yourself. ;-) Junio generally gives good
>> advice, but if you don't see the wisdom in it, that's the time to ask
>> questions, not blindly do a wrong thing.
>
> To be honest it's still not clear to me what was wrong with patch (2).
For example.
diff --git a/builtin/commit.c b/builtin/commit.c
index 5286432..51ee2e5 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -962,6 +962,7 @@ static const char *find_author_by_nickname(const char *name)
return strbuf_detach(&buf, NULL);
}
die(_("No existing author found with '%s'"), name);
+ return NULL;
}
When the above is applied and compiled without NO_NORETURN, the extra
return may be optimized out by the compiler as your commit log messages
said, but wouldn't it introduce a new warning:
builtin/commit.c: In function 'find_author_by_nickname':
builtin/commit.c:965: error: will never be executed
under -Wunreachable-code?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html