> Sorry, I do not recall suggesting to add these dummy returns. The NO_NORETURN > workaround (your [1/3]) is what I remember. It was just a logical followup to quelch the warning storm NO_NORETURN caused. > > >> these will introduce noise for build without NO_NORETURN (either when > >> profile feedback is not used, or when profile feedback build is in use and > >> it no longer requires the NO_NORETURN workaround). > > > > I fixed the noise in a followon patch. > > I suspect that we are talking about different warnings. > > The extra unreachable returns this patch adds will introduce more > "unreachable code" warnings, which was what my message you are responding > to is about. Hmm I didn't see any additional warnings from the patch, neither in profile feedback nor in a normal build with gcc 4.5. Did I miss something? -Andi -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html