Hi Andi, Andi Kleen wrote: >> Sorry, I do not recall suggesting to add these dummy returns. The NO_NORETURN >> workaround (your [1/3]) is what I remember. > > It was just a logical followup to quelch the warning storm NO_NORETURN > caused. Please remember to think for yourself. ;-) Junio generally gives good advice, but if you don't see the wisdom in it, that's the time to ask questions, not blindly do a wrong thing. In this case, since the NO_NORETURN knob is to work around a gcc bug, wouldn't it make sense to add a -Wno-something-or-other option to BASIC_CFLAGS or COMPAT_CFLAGS when it is set? Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html