> Please remember to think for yourself. ;-) Junio generally gives good > advice, but if you don't see the wisdom in it, that's the time to ask > questions, not blindly do a wrong thing. To be honest it's still not clear to me what was wrong with patch (2). > > In this case, since the NO_NORETURN knob is to work around a gcc bug, > wouldn't it make sense to add a -Wno-something-or-other option to > BASIC_CFLAGS or COMPAT_CFLAGS when it is set? The problem is that only relatively new gccs have options to do fine grained control on all warnings. So this would add more complications in the Makefile to check the compiler version (I haven't checked if that's true for this particular warning, but I have run into this several times in the past for others) -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html