Junio C Hamano <gitster@xxxxxxxxx> writes: > I think this is probably a bad move, given that the previous patch is a > temporary workaround until gcc 4.6 is fixed. With -Wunreachable-code on, > these will introduce noise for build without NO_NORETURN (either when > profile feedback is not used, or when profile feedback build is in use and > it no longer requires the NO_NORETURN workaround). I would need to clarify with s/introduce noise/introduce more noise/; the existing codebase is not noise-free. But I do not see much point in making things worse, only to squelch "reaches end of non void function" warnings that will be given under the NO_NORETURN workaround configuration. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html