On Tue, Jan 04, 2011 at 12:53:43AM +0100, Peter Korsgaard wrote:
> >>>>> "Sascha" == Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes:
>
> Sascha> Ok, I can see your problem. I think we should rather define a
> Sascha> board specific function to display a banner than a string, so
> Sascha> something like:
>
> Sascha> config BOARD_BANNER
> Sascha> bool
>
> Sascha> #ifdef CONFIG_BOARD_BANNER
> Sascha> display_board_banner();
> Sascha> #else
> Sascha> printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> Sascha> #endif
>
> Even better, stick:
>
> #ifdef CONFIG_BOARD_BANNER
> extern void display_board_banner(void);
> #else
> static inline void display_board_banner(void)
> {
> printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> }
> #endif
>
The printing of version_string is missing. We could add it to
display_board_banner, but I really would like to keep this in a
generic place to make sure barebox is recognizable by both users
and automatic scripts. Or does anybody wants to fully customize
the initial output of barebox?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
