On Mon, Jan 03, 2011 at 01:45:18PM +0100, Franck JULLIEN wrote:
> 2011/1/3 Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>
>
> I know CONFIG_BOARDINFO is board specific. However, I think it is more
> conveniant
> to have the possibility to define a banner text outside the Kconfig. For
> example, I use
> this in my config.h:
>
> #define CONFIG_BOARD_BANNER_TEXT "\e[1;32m\
> ***********************************************************************\n\
> * Communication board bootloader (ODSFT0152) *\n\
> ************************************************************************\
> \e[0m\n\n"
>
> So may be we could define this kind of banner in the Kconfig.....
Ok, I can see your problem. I think we should rather define a board
specific function to display a banner than a string, so something like:
config BOARD_BANNER
bool
#ifdef CONFIG_BOARD_BANNER
display_board_banner();
#else
printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
#endif
This way we can also show runtime dependent information in the banner
(like baseboard or whatever).
>
> Let me know if you don't like this. This patch was kind of a test for me and
> we could
> forget about it.
>
> Although this patch was very small, we had a lot of discussion around it and
> I don't want to imagine what it is going to be when I submit the nios2 port :)
Don't worry, the amount of comments you receive usually is not
proportional to the patch size you send ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
