Hi Franck,
On Thu, Dec 30, 2010 at 01:49:34PM +0100, Franck JULLIEN wrote:
> Allow a board specific fancy banner
>
> ---
>
> I removed the default fancy banner and do it like Jean-Christophe suggested it.
>
> common/Kconfig | 6 ++++++
> common/console.c | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 617f640..d32c1ce 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
> Allow to set PS1 from the command line. PS1 can have several escaped commands
> like \h for CONFIG_BOARDINFO or \w for the current working directory.
>
> +config BOARD_BANNER
> + bool
> + prompt "allow a board specific fancy banner"
> + help
> + Allow to define a custom board banner (you can define CONFIG_BOARD_BANNER_TEXT in your config.h)
> +
> config HUSH_GETOPT
> bool
> depends on SHELL_HUSH
> diff --git a/common/console.c b/common/console.c
> index 82786f2..7caef11 100644
> --- a/common/console.c
> +++ b/common/console.c
> @@ -46,7 +46,12 @@ EXPORT_SYMBOL(console_list);
> static void display_banner (void)
> {
> printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
> - printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> +
> +#ifndef CONFIG_BOARD_BANNER
> +#undef CONFIG_BOARD_BANNER_TEXT
> +#define CONFIG_BOARD_BANNER_TEXT "Board: " CONFIG_BOARDINFO "\n"
> +#endif
> + printf(RELOC(CONFIG_BOARD_BANNER_TEXT));
> }
I do not really understand this patch. CONFIG_BOARDINFO is board
specific already, why would we want to add another option?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
