Re: [PATCH v2] Revert "PCI: imx6: Add support for active-low reset GPIO"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fabio Estevam <festevam@xxxxxxxxx> [2016-03-30 10:07:16]:

> If we apply Krzysztof's patch then we break PCI in imx6qdl-sabresd.
> 
> In this board we have:
> 
> reset-gpio = <&gpio7 12 0>;
> 
> , which is wrong. Of course, we should fix this to be 'reset-gpio =
> <&gpio7 12 GPIO_ACTIVE_LOW>;'
> 
> However we should not break old dtb's. That's why reverting the patch
> is the only solution we have so that old dtb's still work.

But this only apply for stable right? I understand this and it's fine with me.

> We have had this same problem for the FEC PHY reset. The solution
> there was to add a new property to treat the active-high case.

In next we should fix it correctly, apply Krzysztof's patch and fix broken
DTBs, right?

-- ynezz
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]