Hi Petr, On Wed, Mar 30, 2016 at 9:21 AM, Petr Štetiar <ynezz@xxxxxxx> wrote: > It's just a nitpick :-) but this commit doesn't set the polarity in the wrong > logic level, Yes, it does. That's why it causes regressions. > as you can see, the polarity was simply wrong from the beginning[1]. My patch > has just probably made the error more exposed. No, polarity was active low since the beginning. In order to make the Toradex board to work without breaking old dtb's is to introduce a property like 'phy-reset-active-high' and handle it in the driver. Take a look at the FEC driver for a an example: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/ethernet/freescale/fec_main.c?id=962d8cdc3133435aed2928637f73e272128a326c -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html