Re: [PATCH v2] Revert "PCI: imx6: Add support for active-low reset GPIO"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Fabio Estevam <festevam@xxxxxxxxx> [2016-03-30 09:36:35]:

Hi Fabio,

> In order to make the Toradex board to work without breaking old dtb's is to
> introduce a property like 'phy-reset-active-high' and handle it in the
> driver.

do we really need to do this?  With Krzysztof's patch it should work for both
cases correctly. If I understand gpiolib correctly, you don't need to
introduce reset-active-high, if you use gpiod_* functions, then the GPIO
polarity is handled correctly inside the gpiolib framework[1] and all you need
is to define pin's polarity correctly via gpio pin definition. Or am I missing
something?

Then we need to just fix the broken DTBs.

1. http://lxr.free-electrons.com/source/drivers/gpio/gpiolib.c#L1759

-- ynezz
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]