Hi Petr, On Wed, Mar 30, 2016 at 10:00 AM, Petr Štetiar <ynezz@xxxxxxx> wrote: > do we really need to do this? With Krzysztof's patch it should work for both > cases correctly. If I understand gpiolib correctly, you don't need to > introduce reset-active-high, if you use gpiod_* functions, then the GPIO > polarity is handled correctly inside the gpiolib framework[1] and all you need > is to define pin's polarity correctly via gpio pin definition. Or am I missing > something? > > Then we need to just fix the broken DTBs. If we apply Krzysztof's patch then we break PCI in imx6qdl-sabresd. In this board we have: reset-gpio = <&gpio7 12 0>; , which is wrong. Of course, we should fix this to be 'reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;' However we should not break old dtb's. That's why reverting the patch is the only solution we have so that old dtb's still work. We have had this same problem for the FEC PHY reset. The solution there was to add a new property to treat the active-high case. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html