Tim Harvey <tharvey@xxxxxxxxxxxxx> [2016-03-29 06:43:19]: > > Commit 5c5fb40de8f14 ("PCI: imx6: Add support for active-low reset GPIO") > > cause regressions on some boards like MX6 Gateworks Ventana, for example. Sorry for the problems. > > The reason for the breakage is that this commit sets the gpio polarity > > in the wrong logic level. It's just a nitpick :-) but this commit doesn't set the polarity in the wrong logic level, > > - if (imx6_pcie->reset_gpio) { > > - gpiod_set_value_cansleep(imx6_pcie->reset_gpio, 0); > > + if (gpio_is_valid(imx6_pcie->reset_gpio)) { > > + gpio_set_value_cansleep(imx6_pcie->reset_gpio, 0); > > msleep(100); > > - gpiod_set_value_cansleep(imx6_pcie->reset_gpio, 1); > > + gpio_set_value_cansleep(imx6_pcie->reset_gpio, 1); as you can see, the polarity was simply wrong from the beginning[1]. My patch has just probably made the error more exposed. 1. https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/pci/host/pci-imx6.c?id=bb38919ec56e0758c3ae56dfc091dcde1391353e -- ynezz -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html