taca wrote: > > Hi, it is late reply. > > In message <34433472.post@xxxxxxxxxxxxxxx> > on Fri, 14 Sep 2012 09:35:30 -0700 (PDT), > Tomas Kuliavas <tokul@xxxxxxxxxxxxxxxxxxxxx> wrote: >> taca wrote: >>> Someone created wrapper function to htmlspecialchars() to fix this >>> problem. This patch contains "jaJP" in its filename but it isn't >>> Japanese specific fix at all. >>> >>> http://doga.jp/~taka2/archive/squirrelmail-webmail-1.4.22-PHP54jaJP_20120705taka2.diff >>> >> >> Instead of copying syntax from PHP manual, code should ignore idiocy >> written >> there and use only ENT_COMPAT. ENT_HTML401 introduces backwards >> compatibility break and does nothing. > I don't understand what you meant. ENT_COMPAT or ENT_HTML401 change > default charset of htmlspecialchars()? > ENT_HTML401 constant is introduced only in PHP 5.4. Its value is 0. This constant does not change 'htmlspecialchars($string, ENT_COMPAT | ENT_HTML401, $encoding);' call results. Function will follow only ENT_COMPAT specification due to zero value set on ENT_HTML401. Your proposed patch introduces backwards compatibility break. Constant is not available in older PHP versions. It also follows broken PHP documentation synopsis, which PHP developers refused to fix. -- Tomas -- View this message in context: http://old.nabble.com/Blank-message-body-on-some-replies-tp34348279p34500886.html Sent from the squirrelmail-users mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html ----- squirrelmail-users mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx List archives: http://news.gmane.org/gmane.mail.squirrelmail.user List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
