Re: Blank message body on some replies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Queued Queuedington wrote:
> 
> 
> 
> Tomas Kuliavas wrote:
>> 
>> 
>> Queued Queuedington wrote:
>>> 
>>> Is the "correct" thing to do, perhaps, converting everything to utf8
>>> that's received in a different character set?
>>> 
>> Charset conversions are costly. Some converters have special function
>> dependencies or very large mapping tables. In this case application only
>> needs to sanitize three symbols.
>> 
>> Correct fix is to update every htmlspecialchars function call to less
>> picky iso-8859-1 htmlspecialchars version. Application is dealing with
>> external inputs and these inputs can contain anything. 5.4
>> htmlspecialchars function is fubared. It is supposed to return sanitized
>> text, but it freaks out any non critical format error. Any normal text
>> viewer would follow utf-8 specs and display unknown symbol instead of
>> those broken byte sequences.
>> 
>> -- 
>> Tomas
>> 
> 
> At the risk of further imposing, your fix takes care of the reply being
> blank, do you happen to know the fix, or the section of code to look at,
> to take care of the paragraph that disappears when the mail is first read?
> 
> 
http://pastebin.com/sWJTzGCL

functions/i18n.php - charset_decode() function used to convert text from
different charsets.

Fix should deal with main text body conversion issues, but I would not trust
any htmlspecialchars() call without third argument in PHP 5.4.

-- 
Tomas
-- 
View this message in context: http://old.nabble.com/Blank-message-body-on-some-replies-tp34348279p34375004.html
Sent from the squirrelmail-users mailing list archive at Nabble.com.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users


[Index of Archives]     [Video For Linux]     [Yosemite News]     [Yosemite Photos]     [gtk]     [KDE]     [Cyrus SASL]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux