On Thu, Jul 31, 2008 at 12:40 PM, Alan in Toronto <Alantoronto@xxxxxxxxxxxxxxx> wrote: > On Sun, May 11, 2008 11:27 pm, Jon Angliss wrote: >> Jonathan Angliss wrote: >>> Alan, >>> >>> >>>> On Mon, April 28, 2008 2:36 pm, Alan in Toronto wrote: >>>> >>>>>>> Matching of Alternate Identity is not working in my SM 1.4.13. >>>>>>> >>> >>> >>>>>>> It works in 1.4.9a: when I Reply to a message addressed to an >>>>>>> alternate identity, >>>>>>> SM >>>>>>> automatically inserts that alternate identity into the From address. >>>>>>> >>> >>> >>>>>>> SM 1.4.13 does not insert the alternate identity in to the From on >>>>>>> replies. >>>>>>> I tested with all plugins disabled and the result is the same. >>>>>>> >>> >>> >>>>>> I'm not able to reproduce this issue. I have several identities that I >>>>>> use regularly that match without issues. Are you in the to:? cc? >>>>>> >>> >>> >>>>> Some other odd behaviour, in case it gives you an idea: >>>>> >>>>> - if I email FROM my default identity to an alternate identity, then >>>>> reply, it never >>>>> inserts the alternate identity in the From as it should and as 1.4.9a >>>>> did. >>>>> - if I email FROM an alternate identity (e.g. Bob) to another alternate >>>>> identity >>>>> (e.g. Sally), then reply, it mistakently inserts the original sender's >>>>> FROM >>>>> (Bob)rather than the identity to which the message was sent (Sally), so >>>>> the reply is >>>>> actually going from the original sender and to that same sender. >>>>> >>>>> So, this is rather odd behaviour and I can't yet give exact conditions >>>>> to predict >>>>> behaviour. What I know for sure at the moment is that the functionality >>>>> is not >>>>> working properly and not working as it did in 1.4.9a. >>>>> >>>>> Let me know what else you'd like me to check. >>>>> >>> >>> >>>> Any follow-up on this? Anything further you'd like me to check, or would >>>> you like a test account on the server? I wasn't the only one to report >>>> this, so it's not unique to my installation. >>>> >>> >>> Sorry about the delay in replying, I've been snowed under at work. I've >>> just given the test case a whirl, and managed to reproduce the issue. >>> I'll take a look at the code, and figure out what's going on. >>> >> >> Okay, I know what it's doing here. In src/compose.php it's taking the >> original sender address, and comparing it to the identities you have. >> This is probably setup this way to allow resume of drafts to pick up the >> right identity. The issue you have is that the original sender on the >> reply is also being match. Because it's being matched, it's skipping >> over the rest of the code. >> >> The reason it worked in 1.4.9a is that the identities code was optimized >> after that release due to a security issue. It's also written slightly >> differently, which is probably part of the cause. I'll take a look, and >> see what we changed to work it like this. > > The problem persists in 1.4.15. Sorry for the long delay. The problem is fixed in 1.4.17SVN and 1.5.2SVN. If you want the patch sooner go here for 1.5.2: http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/trunk/squirrelmail/src/compose.php?view=patch&r1=13306&r2=13305&pathrev=13306 Here for 1.4.x: http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/src/compose.php?view=patch&r1=13307&r2=13306&pathrev=13307 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ ----- squirrelmail-users mailing list Posting guidelines: http://squirrelmail.org/postingguidelines List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx List archives: http://news.gmane.org/gmane.mail.squirrelmail.user List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
