Re: Not matching Alternate Identity on replies in SM 1.4.13

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Angliss wrote:
> Alan,
>
>   
>> On Mon, April 28, 2008 2:36 pm, Alan in Toronto wrote:
>>     
>>>>> Matching of Alternate Identity is not working in my SM 1.4.13.
>>>>>           
>
>   
>>>>> It works in 1.4.9a: when I Reply to a message addressed to an
>>>>> alternate identity,
>>>>> SM
>>>>> automatically inserts that alternate identity into the From address.
>>>>>           
>
>   
>>>>> SM 1.4.13 does not insert the alternate identity in to the From on
>>>>> replies.
>>>>> I tested with all plugins disabled and the result is the same.
>>>>>           
>
>   
>>>> I'm not able to reproduce this issue.  I have several identities that I
>>>> use regularly that match without issues.  Are you in the to:? cc?
>>>>         
>
>   
>>> Some other odd behaviour, in case it gives you an idea:
>>>
>>> - if I email FROM my default identity to an alternate identity, then
>>> reply, it never
>>>  inserts the alternate identity in the From as it should and as 1.4.9a
>>> did.
>>> - if I email FROM an alternate identity (e.g. Bob) to another alternate
>>> identity
>>> (e.g. Sally), then reply, it mistakently inserts the original sender's
>>> FROM
>>> (Bob)rather than the identity to which the message was sent (Sally), so
>>> the reply is
>>> actually going from the original sender and to that same sender.
>>>
>>> So, this is rather odd behaviour and I can't yet give exact conditions
>>> to predict
>>> behaviour. What I know for sure at the moment is that the functionality
>>> is not
>>> working properly and not working as it did in 1.4.9a.
>>>
>>> Let me know what else you'd like me to check.
>>>       
>
>   
>> Any follow-up on this? Anything further you'd like me to check, or would
>> you like a test account on the server? I wasn't the only one to report
>> this, so it's not unique to my installation.
>>     
>
> Sorry about the delay in replying, I've been snowed under at work.  I've
> just given the test case a whirl, and managed to reproduce the issue. 
> I'll take a look at the code, and figure out what's going on.
>   

Okay, I know what it's doing here.  In src/compose.php it's taking the 
original sender address, and comparing it to the identities you have.  
This is probably setup this way to allow resume of drafts to pick up the 
right identity.  The issue you have is that the original sender on the 
reply is also being match.  Because it's being matched, it's skipping 
over the rest of the code.

The reason it worked in 1.4.9a is that the identities code was optimized 
after that release due to a security issue.   It's also written slightly 
differently, which is probably part of the cause.  I'll take a look, and 
see what we changed to work it like this.

-- 
Jon Angliss
<jon@xxxxxxxxxxx>



-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
-----
squirrelmail-users mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-users@xxxxxxxxxxxxxxxxxxxxx
List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

[Index of Archives]     [Video For Linux]     [Yosemite News]     [Yosemite Photos]     [gtk]     [KDE]     [Cyrus SASL]     [Gimp on Windows]     [Steve's Art]     [Webcams]

  Powered by Linux