On Thu, Jul 7, 2022 at 6:52 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 7 Jul 2022 18:35:12 -0600 Yu Zhao <yuzhao@xxxxxxxxxx> wrote:
>
> > > This relentless drive towards mm-stable: I for one cannot keep up.
> > > I'd like to ask for slowing down a bit - my intention had been to
> > > reach testing maple tree again (it's not yet what I'd call stable),
> > > but this and a couple of other issues got in the way. More mails
> > > to write.
> >
> > Sorry for not being clear (it doesn't seem confusing to me because I
> > don't trust the bot):
> >
> > There were two reports, the first one [1] tested v4 without the fix
> > [2]; the second one [3] tested v5 at patch 5/7 (not the whole series).
> >
> > v4 + the fix is good; v5 the whole series is good.
> >
> > Please do not drop patch 7/7 and do not add this fix.
>
> As Vlastimil has sleuthed out that the
> "BUG:sleeping_function_called_from_invalid_context_at_mm/gup.c"
> reporter was using the v4 series, I've restored 7/7 ("mm/page_alloc:
> replace local_lock with normal spinlock") for tomorrow's linux-next.
Yes, the bot initially tried v4 without the fix and reported the
problem. And Oliver manually tried again under the impression he had
the fix [1]. But that's the real fix [2]; it's just a cleanup.
[1] https://lore.kernel.org/r/YsRB3fZHAfik0M%2Fq@xsang-OptiPlex-9020/
[2] https://lore.kernel.org/r/20220615160446.be1f75fd256d67e57b27a9fc@xxxxxxxxxxxxxxxxxxxx/
> I retained this fix against 2/7 and reworked 7/7 appropriately. So it
> is now
Awesome.
