Re: + mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/8/22 00:09, Yu Zhao wrote:
> On Thu, Jul 7, 2022 at 3:58 PM Vlastimil Babka <vbabka@xxxxxxx> wrote:
>>
>> On 7/7/22 22:09, Andrew Morton wrote:
>> > The patch titled
>> >      Subject: mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
>> > has been added to the -mm mm-unstable branch.  Its filename is
>> >      mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch
>> >
>> > This patch will shortly appear at
>> >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch
>> >
>> > This patch will later appear in the mm-unstable branch at
>> >     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> >
>> > Before you just go and hit "reply", please:
>> >    a) Consider who else should be cc'ed
>> >    b) Prefer to cc a suitable mailing list as well
>> >    c) Ideally: find the original patch on the mailing list and do a
>> >       reply-to-all to that, adding suitable additional cc's
>> >
>> > *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>> >
>> > The -mm tree is included into linux-next via the mm-everything
>> > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> > and is updated there every 2-3 working days
>> >
>> > ------------------------------------------------------
>> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>> > Subject: mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
>> > Date: Thu Jul  7 01:06:35 PM PDT 2022
>> >
>> > add missing local_unlock_irqrestore() on contention path
>>
>> Doh, that's true and something to fix, although patch 7 did remove the bug
>> later in the same series so that wouldn't explain the lkp report for patch
>> 7. The reason lkp test robot complained was AFAICS that it was testing v4,
>> as I just replied there.
> 
> Sorry I didn't bother to reply until now: it did test v5, at this
> commit, not the whole series.

I meant this report that appears to be for v4 (full series including patch 7):
https://lore.kernel.org/all/YsFk%2FqU+QtWun04h@xsang-OptiPlex-9020/
That reported a bug due to missing unpin that was previously reported for v4
and fixed in v5.

I'm not aware of a lkp report for v5 (found only Dan's) but yeah, hitting
the (similar but not identical) bug fixed by this -fix would indeed be
possible in v5 if patch 7 was not applied.



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux