Re: + mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/7/22 22:09, Andrew Morton wrote:
> The patch titled
>      Subject: mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
> has been added to the -mm mm-unstable branch.  Its filename is
>      mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch
> 
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
> Date: Thu Jul  7 01:06:35 PM PDT 2022
> 
> add missing local_unlock_irqrestore() on contention path

Doh, that's true and something to fix, although patch 7 did remove the bug
later in the same series so that wouldn't explain the lkp report for patch
7. The reason lkp test robot complained was AFAICS that it was testing v4,
as I just replied there.

> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Hugh Dickins <hughd@xxxxxxxxxx>
> Cc: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxxxx>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Cc: Nicolas Saenz Julienne <nsaenzju@xxxxxxxxxx>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Yu Zhao <yuzhao@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  mm/page_alloc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/mm/page_alloc.c~mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix
> +++ a/mm/page_alloc.c
> @@ -3792,6 +3792,7 @@ static struct page *rmqueue_pcplist(stru
>  	pcp_trylock_prepare(UP_flags);
>  	if (!spin_trylock(&pcp->lock)) {
>  		pcp_trylock_finish(UP_flags);
> +		local_unlock_irqrestore(&pagesets.lock, flags);
>  		return NULL;
>  	}
>  
> _
> 
> Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
> 
> android-binder-stop-saving-a-pointer-to-the-vma-fix.patch
> mm-remove-the-vma-linked-list-fix-2-fix.patch
> mm-drop-oom-code-from-exit_mmap-fix-fix.patch
> mm-add-merging-after-mremap-resize-checkpatch-fixes.patch
> mm-factor-helpers-for-memory_failure_dev_pagemap-fix.patch
> xfs-support-cow-in-fsdax-mode-fix.patch
> mm-thp-kill-transparent_hugepage_active-fix.patch
> mm-thp-kill-transparent_hugepage_active-fix-fix.patch
> mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix.patch
> x86-mm-move-protection_map-inside-the-platform-fix.patch
> 




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux