-----Original Message----- From: David Daney [mailto:ddaney@xxxxxxxxxxxxxxxxxx] Sent: Monday, May 22, 2017 6:26 PM To: Maciej W. Rozycki <macro@xxxxxxxxxx>; Petar Jovanovic <Petar.Jovanovic@xxxxxxxxxx> Cc: Petar Jovanovic <petar.jovanovic@xxxxxxxxx>; linux-mips@xxxxxxxxxxxxxx; ralf@xxxxxxxxxxxxxx; david.daney@xxxxxxxxxx Subject: Re: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1 On 05/20/2017 06:37 PM, Maciej W. Rozycki wrote: >> I suspect it will affect more than just `show_cpuinfo', e.g. some inline >> asm, and you could have included a justification as to why this patch is >> correct, such as by referring to how `set_isa' sets flags in `isa_level'. > That is correct, and exactly what I said in my reply to the patch when > it was posted. When the OCTEON code was merged, different code paths > were taken in the kernel, and there was a deliberate decision to > structure mach-cavium-octeon/cpu-feature-overrides.h the way we did it. In the current ToT, I have not seen where this change would affect apart from show_cpuinfo(). I understood from your words it was different at the time when the original patch was added. Petar
