On Fri, 14 May 2004 15:15:26 -0700
Greg KH <greg at kroah.com> wrote:
> On Sat, May 08, 2004 at 04:47:18PM +0400, Evgeniy Polyakov wrote:
> > This patchset is in -p1 form with minor cleanup.
> > Please apply instead of previous.
>
> Your coding style is still incorect with regards to the initial
> placement of the { character in a number of places. Please fix this.
Grr...
I've installed <fill yourself> indent and think that even oldmen
Kernighan and Ritchie would like this patch :)
> Also:
> > +ifeq ($(CONFIG_W1),y)
> > +obj-$(CONFIG_W1) += w1.o w1_int.o w1_family.o w1_netlink.o w1_io.o
> > +endif
> > +
> > +ifeq ($(CONFIG_W1),m)
> > +obj-m += wire.o
> > +wire-objs := w1.o w1_int.o w1_family.o w1_netlink.o w1_io.o
> > +endif
>
> Why the difference here? Can't this be written as:
>
> obj-$(CONFIG_W1) += wire.o
> wire-objs := w1.o \
> w1_int.o \
> w1_family.o \
> w1_netlink.o \
> w1_io.o
>
> That should do the same thing, right?
Yes it does, although the former variant doesn't generate unneded
object in case of non-modular build, but your variant is more clear.
> thanks,
Thank you.
> greg k-h
Evgeniy Polyakov ( s0mbre )
Only failure makes us experts. -- Theo de Raadt
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: MAINTAINERS.diff
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040515/c5d25d04/attachment.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: drivers_Kconfig.diff
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040515/c5d25d04/attachment-0001.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: drivers_Makefile.diff
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040515/c5d25d04/attachment-0002.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: w1.diff
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040515/c5d25d04/attachment-0003.pl
