On Sat, May 08, 2004 at 04:47:18PM +0400, Evgeniy Polyakov wrote:
> This patchset is in -p1 form with minor cleanup.
> Please apply instead of previous.
Your coding style is still incorect with regards to the initial
placement of the { character in a number of places. Please fix this.
Also:
> +ifeq ($(CONFIG_W1),y)
> +obj-$(CONFIG_W1) += w1.o w1_int.o w1_family.o w1_netlink.o w1_io.o
> +endif
> +
> +ifeq ($(CONFIG_W1),m)
> +obj-m += wire.o
> +wire-objs := w1.o w1_int.o w1_family.o w1_netlink.o w1_io.o
> +endif
Why the difference here? Can't this be written as:
obj-$(CONFIG_W1) += wire.o
wire-objs := w1.o \
w1_int.o \
w1_family.o \
w1_netlink.o \
w1_io.o
That should do the same thing, right?
thanks,
greg k-h
