On Fri, 7 May 2004 14:54:41 -0700 Greg KH <greg at kroah.com> wrote: > On Fri, May 07, 2004 at 11:37:27AM +0400, Evgeniy Polyakov wrote: > > Hello. > > > > This patchset against 2.6 linux kernel implements Dallas's 1-wire > > protocol. All technical issues discussed before are successfully > > resolved. > > But the non-technical ones aren't :) > > - you still have the incorrect style for your "if" statement > brace placement, please fix it. Hmm. _Personally_ I strongly disagree with it. But I suppose You strongly disagree with my disagreement :) Although I prefer previous brace placement attached patch contains "CodingStyle" placement. > - I thought you were going to get rid of the #ifdef stuff for > your reading and writing to memory locations? Done. > - you are createing static struct device variables. Are you > _sure_ this is ok (think holding a reference to the device > through sysfs and removing the module from the kernel...) Module _may_not_ be unloaded until reference counter is not zero. module_exit() and friends will reschedule task until reference counter hits zero in every place where it is needed. > - your patches contain no way to add your code to the kernel > build system or the configuration system. Done. > thanks, > > greg k-h Thank you Greg. I also want to thank Mark Studebaker <mds4 at verizon.net> for technical discussion, Petr Vandrovec <VANDROVE at vc.cvut.cz> for discussion about matrox's gpio bits and Alexander Yurchenko <grange at openbsd.org> for initial idea and cause. Evgeniy Polyakov ( s0mbre ) Only failure makes us experts. -- Theo de Raadt -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: w1.diff Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040508/410e36bb/attachment.pl -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: MAINTAINERS.diff Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040508/410e36bb/attachment-0001.pl -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: drivers_Makefile.diff Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040508/410e36bb/attachment-0002.pl -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: drivers_Kconfig.diff Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040508/410e36bb/attachment-0003.pl
