On Fri, May 07, 2004 at 11:37:27AM +0400, Evgeniy Polyakov wrote: > Hello. > > This patchset against 2.6 linux kernel implements Dallas's 1-wire protocol. > All technical issues discussed before are successfully resolved. But the non-technical ones aren't :) - you still have the incorrect style for your "if" statement brace placement, please fix it. - I thought you were going to get rid of the #ifdef stuff for your reading and writing to memory locations? - you are createing static struct device variables. Are you _sure_ this is ok (think holding a reference to the device through sysfs and removing the module from the kernel...) - your patches contain no way to add your code to the kernel build system or the configuration system. thanks, greg k-h
