> > > So far my experience has been (at least in 2.4) that usually > > > header files don't include all required headers themselves, > > > relying on *.c to include everything properly (maybe it's just > > > on PPC though). > > > > Such headers are broken and need fixing IMHO. > > Maybe, are you going to fix them all _before_ changing i2c layer :) > ? I am certainly not. > I agree it's a mess, but removing config.h you might break code which > is fine right now. Is such clean up worth it? I think it is, as long as we are working on the HEAD of Linux. However, what I think is obviously not what matters, what Greg thinks is. Thanks. -- Jean Delvare http://www.ensicaen.ismra.fr/~delvare/