[TRIVIAL 2.6] drivers/i2c/busses/i2c-piix4.c: kill duplicate #include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > So far my experience has been (at least in 2.4) that usually
> > > header files don't include all required headers themselves,
> > > relying on *.c to include everything properly (maybe it's just
> > > on PPC though).
> > 
> > Such headers are broken and need fixing IMHO.
> 
> Maybe, are you going to fix them all _before_ changing i2c layer :)
> ?

I am certainly not.

> I agree it's a mess, but removing config.h you might break code which
> is fine right now. Is such clean up worth it?

I think it is, as long as we are working on the HEAD of Linux. However,
what I think is obviously not what matters, what Greg thinks is.

Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux