[TRIVIAL 2.6] drivers/i2c/busses/i2c-piix4.c: kill duplicate #include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Maybe I'm missing something but since when <linux/config.h> is not
> needed?
> 
> Are you sure this change will not break build on some archs/configs?

I am assuming that #include <linux/config.h> is needed if and only if
the code makes use of any CONFIG_* value. Am I wrong?

> So far my experience has been (at least in 2.4) that usually header
> files don't include all required headers themselves, relying on *.c to
> include everything properly (maybe it's just on PPC though).

Such headers are broken and need fixing IMHO.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux