On Thu, 14 Apr 2011 06:06:26 -0700 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Apr 14, 2011 at 12:39:12PM +0200, Antonio Ospite wrote: > > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > Should remove do platform_set_drvdata(pdev, NULL)? > > > AFAICS this is not strictly necessary because we never check for NULL > > here and we are setting drvdata again in _probe() each time the module > > is loaded anyways. If it is considered a good practice for symmetry > > reasons then I'll add it, no problem. Does anyone have comments on that? > > We went round this loop with I2C - anything peering at driver data that > it didn't originally set is buggy anyway so no need to reset to zero. > If there was a need the platform bus or driver core should do it since > all devices would need it. > Ok, so v3 is the one which could be merged. John if you are the one who is going to commit it, would you please add the line: Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> Thanks everybody for the comments. Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpODPBlp7FN0.pgp
Description: PGP signature
