On Tue, 12 Apr 2011 13:41:28 +0200 Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > + dev_info(&pdev->dev, "initialized\n"); > > Is that message really useful? > I can print the pdata->name here as well as an excuse to keep it, reality is that I just like visual feedback in dmesg when a driver has been loaded. > Other than that, looks good to me. > > johannes > In another message you said that the comment in rfkill-regulator.h still seemed a little wrong to you, would you elaborate more about what you were referring to? Thanks, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Attachment:
pgpT2w8WQ2_yL.pgp
Description: PGP signature
