On Wed, 2011-04-13 at 21:40 +0200, Antonio Ospite wrote:
> +static int __devinit rfkill_regulator_probe(struct platform_device *pdev)
...
> + platform_set_drvdata(pdev, rfkill_data);
> +static int __devexit rfkill_regulator_remove(struct platform_device *pdev)
> +{
> + struct rfkill_regulator_data *rfkill_data = platform_get_drvdata(pdev);
> + struct rfkill *rf_kill = rfkill_data->rf_kill;
> +
> + rfkill_unregister(rf_kill);
> + rfkill_destroy(rf_kill);
> + regulator_put(rfkill_data->vcc);
> + kfree(rfkill_data);
> +
> + return 0;
> +}
Should remove do platform_set_drvdata(pdev, NULL)?
In any case, that's the only thing I see now and I did read the code
carefully, so if that's not necessary:
Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Otherwise, feel free to include that in v4.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
