On Thu, Apr 14, 2011 at 12:39:12PM +0200, Antonio Ospite wrote: > Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > Should remove do platform_set_drvdata(pdev, NULL)? > AFAICS this is not strictly necessary because we never check for NULL > here and we are setting drvdata again in _probe() each time the module > is loaded anyways. If it is considered a good practice for symmetry > reasons then I'll add it, no problem. Does anyone has comments on that? We went round this loop with I2C - anything peering at driver data that it didn't originally set is buggy anyway so no need to reset to zero. If there was a need the platform bus or driver core should do it since all devices would need it. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html