Re: [PATCH v2 01/37] usb/gadget: use consistent naming scheme for usb function modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Feb 26, 2013 at 06:52:17PM +0100, Andrzej Pietrasiewicz wrote:
> In order to convert to configfs the USB functions need to be converted
> to the new interface from Sebastian, which also requires turning them
> into separate modules. Some of these modules will consist of just
> one object file, e.g. f_ncm.o. But some of the modules will eventually
> consist of more than one object file, e.g. for mass storage there
> will be f_mass_storage.o and storage_common.o. The resulting module
> cannot be called f_mass_storage.ko due to cyclic dependency. This patch
> introduces a naming scheme for the said resulting modules:
> 
> f_xxxxxx_usb.ko
> 
> e.g. f_mass_storage_usb.ko, f_ss_lb_usb.ko, f_rndis_usb.ko etc.

IMHO each function should be a separate module, so this f_ss_lb_usb.ko
is wrong. We should have f_sourcesink.ko and f_loopback.ko.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux