Re: [PATCH 43/49] usb: gadget: omap_udc: don't assign gadget.dev.release directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Feb 26, 2013 at 09:31:32PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-02-2013 17:34, Felipe Balbi wrote:
> 
> >udc-core provides a better way to handle release
> >methods, let's use it.
> 
> >Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> >---
> >  drivers/usb/gadget/omap_udc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
> >index 1e05df6..3ed56c5 100644
> >--- a/drivers/usb/gadget/omap_udc.c
> >+++ b/drivers/usb/gadget/omap_udc.c
> [...]
> >@@ -2901,7 +2900,8 @@ bad_on_1710:
> >  	}
> >
> >  	create_proc_file();
> >-	status = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
> >+	status = usb_add_gadget_udc(&pdev->dev, &udc->gadget,
> 
>   Are you sure it shouldn't be usb_add_gadget_udc_release() like in
> other drivers?

Nice catch :-) I have have fixed the patch and pushed to testing branch
again.

(damn these ARCH dependencies... that's my next target)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux