Re: [PATCH 43/49] usb: gadget: omap_udc: don't assign gadget.dev.release directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 26-02-2013 17:34, Felipe Balbi wrote:

udc-core provides a better way to handle release
methods, let's use it.

Signed-off-by: Felipe Balbi <balbi@xxxxxx>
---
  drivers/usb/gadget/omap_udc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c
index 1e05df6..3ed56c5 100644
--- a/drivers/usb/gadget/omap_udc.c
+++ b/drivers/usb/gadget/omap_udc.c
[...]
@@ -2901,7 +2900,8 @@ bad_on_1710:
  	}

  	create_proc_file();
-	status = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
+	status = usb_add_gadget_udc(&pdev->dev, &udc->gadget,

Are you sure it shouldn't be usb_add_gadget_udc_release() like in other drivers?

+			omap_udc_release);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux